Skip to content

docs(distributed): review frozen multimodal FSDP guidance - #3272

Merged
akoumpa merged 2 commits into
mainfrom
yuhez/docs/review-frozen-multimodal-fsdp
Jul 30, 2026
Merged

docs(distributed): review frozen multimodal FSDP guidance#3272
akoumpa merged 2 commits into
mainfrom
yuhez/docs/review-frozen-multimodal-fsdp

Conversation

@yuhezhang-ai

@yuhezhang-ai yuhezhang-ai commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

This docs-only follow-up completes the technical publications review of the customer-facing documentation introduced by #2763.

  • Applied all editorial suggestions from @jgerh to docs/breaking-changes.mdx.
  • Removed the temporary review markers from both MDX files.
  • Left docs/guides/configuration.mdx unchanged after technical publications review found no edits were needed.

The final PR diff contains only the accepted editorial updates to docs/breaking-changes.mdx.

Validation

  • make -C docs/fern docs-check — MDX validation passed for 452 files; the local Fern CLI was unavailable
  • npx -y fern-api@5.29.0 check — blocked by host WebAssembly memory allocation; PR Fern CI provides the complete check
  • git diff --check origin/main...HEAD — passed

Requested by @jgerh in #2763.

Signed-off-by: Yuhe Zhang <yuhez@nvidia.com>
@yuhezhang-ai
yuhezhang-ai requested review from a team and jgerh as code owners July 28, 2026 17:42
@copy-pr-bot

copy-pr-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yuhezhang-ai yuhezhang-ai added the docs-only With great power comes great responsibility. label Jul 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

@jgerh jgerh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed tech pubs review. No changes needed to docs/guides/configuration.mdx - looks great. Provided minor edits to docs/breaking-changes.mdx.

Comment thread docs/breaking-changes.mdx Outdated

{/* docs-review-start: frozen-multimodal-fsdp-policy */}

Fully frozen vision/audio towers and multimodal projectors now default to the `root` FSDP2 policy. Previously, dense

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Fully frozen vision/audio towers and multimodal projectors now default to the `root` FSDP2 policy. Previously, dense
Fully frozen vision and audio towers and multimodal projectors now default to the `root` FSDP2 policy. Previously, dense

Comment thread docs/breaking-changes.mdx Outdated

### FSDP2 Default `reduce_dtype` Is Now `float32`

The default [`MixedPrecisionPolicy`](https://docs.pytorch.org/docs/stable/distributed.fsdp.fully_shard.html) built by `FSDP2Config` now uses `reduce_dtype=torch.float32` instead of `torch.bfloat16`. Forward/backward compute still uses `param_dtype=torch.bfloat16`, but gradient reduction now accumulates in fp32 to reduce communication-rounding error at larger data-parallel world sizes.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The default [`MixedPrecisionPolicy`](https://docs.pytorch.org/docs/stable/distributed.fsdp.fully_shard.html) built by `FSDP2Config` now uses `reduce_dtype=torch.float32` instead of `torch.bfloat16`. Forward/backward compute still uses `param_dtype=torch.bfloat16`, but gradient reduction now accumulates in fp32 to reduce communication-rounding error at larger data-parallel world sizes.
The default [`MixedPrecisionPolicy`](https://docs.pytorch.org/docs/stable/distributed.fsdp.fully_shard.html) built by `FSDP2Config` now uses `reduce_dtype=torch.float32` instead of `torch.bfloat16`. Forward/backward compute still uses `param_dtype=torch.bfloat16`, but gradient reduction now accumulates in FP32 to reduce communication-rounding error at larger data-parallel world sizes.

Comment thread docs/breaking-changes.mdx Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Kubernetes (through SkyPilot) | `skypilot:` with `cloud: kubernetes` |

Comment thread docs/breaking-changes.mdx Outdated
Comment on lines 111 to 112

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `slurm:` YAML section and all related fields have been removed. Slurm
jobs are now submitted with `sbatch` directly, using a self-contained `sbatch`

Comment thread docs/breaking-changes.mdx Outdated
Comment on lines 123 to 124

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
All cluster-specific configuration lives in the `sbatch` script where you can
edit it directly.

Comment thread docs/breaking-changes.mdx Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The FFmpeg-bearing media dependencies (OpenCV, decord, the Qwen vision utilities, and

Comment thread docs/breaking-changes.mdx Outdated
Comment on lines 156 to 157

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `[vlm]` alone no longer trains Qwen2.5-VL, Qwen3-Omni, or Mistral VLMs. Add `vlm-media`.
- `[all]` no longer includes the media extras. Add them with `uv pip install "nemo-automodel[media]"` in the activated environment.

Comment thread docs/breaking-changes.mdx Outdated
Comment on lines 163 to 164

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The CLI entry point lives at `nemo_automodel/cli/app.py` and is registered as
the `automodel` or `am` console entry points. A thin convenience wrapper

Signed-off-by: Yuhe Zhang <yuhez@nvidia.com>
@yuhezhang-ai
yuhezhang-ai requested a review from jgerh July 29, 2026 22:04
@yuhezhang-ai

Copy link
Copy Markdown
Contributor Author

/ok to test 4560ee1

@yuhezhang-ai yuhezhang-ai added the r0.6.0 Auto-cherrypick to release branch. Apply before merge; cherrypick happens after merge. label Jul 29, 2026
@akoumpa
akoumpa merged commit f1a73d9 into main Jul 30, 2026
40 checks passed
@akoumpa
akoumpa deleted the yuhez/docs/review-frozen-multimodal-fsdp branch July 30, 2026 09:37
akoumpa pushed a commit that referenced this pull request Jul 30, 2026
…` into `r0.6.0` (#3306)

docs(distributed): review frozen multimodal FSDP guidance (#3272)

* docs(distributed): mark frozen multimodal sections for review



* docs(distributed): apply technical publications review



---------

Signed-off-by: Yuhe Zhang <yuhez@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Yuhe Zhang <yuhez@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-only With great power comes great responsibility. r0.6.0 Auto-cherrypick to release branch. Apply before merge; cherrypick happens after merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants